Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with subprob numbering #219

Open
sbihorel opened this issue May 1, 2023 · 0 comments
Open

Issue with subprob numbering #219

sbihorel opened this issue May 1, 2023 · 0 comments

Comments

@sbihorel
Copy link

sbihorel commented May 1, 2023

Hi,

There is an issue in the parse_nm_files function. Subproblems are assigned an index by the following calls

  x <- dplyr::mutate(x, subprob = cumsum(duplicated(!!rlang::sym("problem")) & !is.na(!!rlang::sym("problem"))) + 1)

Let's say that a NONMEM code contains 3 $ESTIMATION records and that the 2nd does not generate any output in the cor/coi/cov/shk files, then the code above will assign the wrong number (2 instead of 3) to the last estimation/subproblem.

I believe that the code should take into account the TABLE number instead of juts summing the number of rows with TABLE N0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants