[3.6] NCV does not give feedback

[klemie]

Description

The NCV valve doesn't seem to send feedback. It gets suck in "in transit" even though the valve hits the limit switch. Probably a firmware problem

Acceptance Criteria

• Ground Support feeback state reflects the actual hardware

QA Notes

Linked issues

[jjderooy]

I read through Controls.ino and don't see any discrepancy between the way NCV is treated compared to the other valves.

Next step is to watch the serial output from the mega and confirm it is correctly reading the limit switches. I tested the switches themselves and they're both good.

@krislemie is it possible it's not a firmware problem and you're not checking for a state or something in the gui? I also remember once Hayden uploaded the code from main on the Hybrid-Controls-System repo, it acted differently so maybe this isn't actually a problem anymore.