Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All LEDs must be lit in switch testing mode #1058

Closed
mondalaci opened this issue Dec 24, 2024 · 3 comments · Fixed by #1062
Closed

All LEDs must be lit in switch testing mode #1058

mondalaci opened this issue Dec 24, 2024 · 3 comments · Fixed by #1062
Assignees

Comments

@mondalaci
Copy link
Member

erase-hardware-config.ts
factory-update-uhk60.ts firmwareDir uhk60v2
write-hardware-config.ts uhk60v2 ansi
set-variable.ts testSwitches 1

After executing the above but before pressing any key, the ANSI LShift LED should be enabled, but it's not on the UHK 60.

image

@mondalaci
Copy link
Member Author

Now all the LEDs light up, but then switch testing only works on the right half.

Pressing a key on the right half makes the LEDs of both halves go out, which is inconsistent with the behavior of the UHK 80 on which the halves work separately in this respect. Afterward pressing keys only on the right half make their LEDs light up, not on the left half.

To reproduce this, the hardware configuration must be erased according to the above instructions.

@kareltucek

This comment was marked as outdated.

@kareltucek
Copy link
Collaborator

Actually, I have been digging into the crc... ...and turns out that crc of an empty message is zero, which obviously isn't ideal, as a zero message contains zero as its crc.

In the light of that a reasonable fix seems to be to require any message to simply be nonzero in addition to having a valid crc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants