Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Jukebox to be a part of the Applikation. #470

Open
jimmyhawkin opened this issue Sep 6, 2024 · 5 comments
Open

Feature Request: Jukebox to be a part of the Applikation. #470

jimmyhawkin opened this issue Sep 6, 2024 · 5 comments

Comments

@jimmyhawkin
Copy link

Issue type: Feature request

Is there anyway we could get a more expanded funktion of the Jukebox were its more a part of Melody Manya and maby has its own Menu to enter the mode? And a more skip, back, Random funktions so you can have musik running on a party in a better way. The mod leaves allot to ask for. Id say the applikation Voxalux does this in a great way were you allso can easy jump in to start singin if theres a song that comes upp that people wanna sing. Its many the only reason i leave Vocalux on the begining of a party and sadly we tend to stay on it aswell cause of this function. It feels sad. Allso sins there so mutch to gain from having a funktion like this one and that you allso get more out of your song and applikation this way.

Maby the Menu item could be down at the Settings icon and just be a Jukebox icon. Allso it could be implamented to work with the Mobile app so you can work with the songs there like you do with queing songs etc. And now have skip or back function so you can controll the musik and select musik from the list.

i will add more pictures and idees shortly i just want my original text here so i have something to work with.

@jimmyhawkin
Copy link
Author

Here is how Vocalux does it with a menu on the top that jumps down when mouse hower.
bild

And id say that basicly who not do the same? And then they have the Jump in to song icon with the mic were it restarts the song and then you can start playing.

This could allso be implemented together with the feuture that others has been asking for that you can select players before a song starts thats in que. Id say that it could be used here aswell in order to select players and mic that wanna sing. Allso Skip and back feature could be used on the main window.

@jimmyhawkin
Copy link
Author

jimmyhawkin commented Sep 9, 2024

Would be great to add jukebox as a part of the application were you can skip songs and go back. And ofc skip should apply a random song then and not next in line. Or have the option in the meny to select what you want. In the middle now we have play and stop. Why not add back and skip in the side of it. And then maby have a top meny were you can select to random songs or choose to restart the song and select plahyer that wanna sing. As already been asked for in que funktion.

I think the best thing would be to add this as its own part of the applikation that is called jukebox. Or do as vocalux and have the ability to make random songs popup in the background when out of the top meny selection.

bild

@jimmyhawkin
Copy link
Author

jimmyhawkin commented Sep 9, 2024

Hope this picture shows what im thinking. Were pause play button changes acording to what state song is in.
And the rest is funktions im thinking should be in a ingame jukebox mode. Or add to the mod. But i dont see why not add this as a feature to the game itself as it adds value to the game. and more reason for people to buy it.

And ofc in the background there should be the song / video of the song running. But yeh if its this design then icons should just be showned when your moving hte mouse around or pressing keyboard left and right. for example
Namnlöst-1

@achimmihca
Copy link
Collaborator

So if I understand correctly then you suggest for the Jukebox mod

  • make it a first class feature of the game
  • buttons to select the next/previous song
    • could be placed left and right of the current play/pause button
  • button to toggle random order (aka. shuffle)
  • change players for a running song

My thoughts on this:

  • I agree that one might expect such next/previous buttons. I think implementing this is rather easy.
    • Select next song: would be same as currently done at the end of the song
    • Select prvious song: would require a song history, which is currently not available. Maybe the mod could store played songs to make this possible.
  • Toggle the random order would need some refactoring
    • Currently, only the song select scene has a defined order. This needs to be centralized in some service class first.
  • Changing players at runtime would not work well with the current implementation
    • Would probably require much more refactoring
    • Current workarounds:
      • use generic players profiles, e.g., Player01 and Player02
      • exit the song, configure players, start song
        • I doubt that doing this from the sing scene instead of from song select would make it that much better

@jimmyhawkin
Copy link
Author

Yeh i mean toggle random is just nice to have. In my opinion im always gonne want it to select random song so thats already there as of now. So thhat could just be a thing for a later time.

Id say you get what im saying and whats importent to exist in this Jukebox function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants