Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags appear to have changed, or can't be read properly for some reason. (Handle unidentified flags) #799

Open
ToughSun14 opened this issue Mar 21, 2022 · 5 comments
Labels
lib The PR or issue is related to "UndertaleModLib"

Comments

@ToughSun14
Copy link

While I was examining the data package for some test compiles on my project, I noticed that the flags line had changed from text to a string of numbers. Either something changed in the data package, or UMT now can't read them for some reason. Either way, I suggest this be looked into.
2022-03-20-edited
Here's the data package in question: https://mega.nz/file/PrQDxahZ#bWQa26VMFI72wUoX7IegzhJUqAmY18eXWixNLH7LM70

@Grossley
Copy link
Collaborator

How flags work is that they're actually a number, it's parsed in a certain way to look like actual flags. The different values added together represent different flags. These are bit flags. So the reason that it's showing up like that is because there is probably an unknown flag that's messing everything up.

Therefore, these new flag(s) need to be identified, added, and also add some sort of error handling to handle future unknown flags.

@Grossley Grossley changed the title Flags appear to have changed, or can't be read properly for some reason. Flags appear to have changed, or can't be read properly for some reason. (Handle unidentified flags) Apr 13, 2022
@Jacky720
Copy link
Contributor

Flags in this data file now show correctly (SyncVertex1, Scale, ShowCursor), but I'm unsure if error handling has been added.

@Miepee
Copy link
Contributor

Miepee commented Feb 19, 2024

Not as far as i'm aware. Should be relatively simple to just add a read.submitWarning or whatever that function is called during tag reading

@ToughSun14
Copy link
Author

Flags in this data file now show correctly (SyncVertex1, Scale, ShowCursor), but I'm unsure if error handling has been added.

Well, it seems to have done something, but it's not exactly what I was looking for when I said flags. I was more talking about the "flags" bar in the "options" section of the general data. That's what doesn't show up properly. (example: in the deltarune demo, the flags section reads "UseNewAudio, ScreenKey, VariableErrors, FastCollisionCompatibility", but in my test compiles it reads a random number string as seen by the image in this thread. Sorry about the confusion, I didn't show that in the old image. Here's a new one that properly shows it)
image_2024-02-19_192756706

@Jacky720
Copy link
Contributor

Oh, I was looking at the regular Flags. Although Deltarune v1.15 also shows numbers in those fields.

@Miepee Miepee added the lib The PR or issue is related to "UndertaleModLib" label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib The PR or issue is related to "UndertaleModLib"
Projects
None yet
Development

No branches or pull requests

4 participants