Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use prettier plugins (such as https://github.com/prettier/plugin-ruby) #141

Open
khuongduybui opened this issue May 3, 2019 · 3 comments
Labels
add language enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@khuongduybui
Copy link

I guess I'm asking for two things here:

  1. Supporting prettier plugins
  2. Supporting Ruby language via prettier plugin for Ruby

I will gladly accept a stop gap provider for Ruby with a different beautifier over no providers at all.'
However, I think the ability to use all prettier plugins will come in handy.

@stevenzeck stevenzeck transferred this issue from Unibeautify/vscode May 7, 2019
@stevenzeck
Copy link
Contributor

stevenzeck commented May 7, 2019

Hi @khuongduybui, it doesn't support it yet, but it can be done. It would be similar to what we did with https://github.com/Unibeautify/beautifier-eslint and eslint-plugin-react. I moved it to this repo because that's where the relevant change would be.

@stevenzeck stevenzeck added the enhancement New feature or request label May 7, 2019
@khuongduybui
Copy link
Author

Anything I can do to help speed things up?

@Glavin001
Copy link
Member

@khuongduybui Pull Requests welcome!

Similar code from beautifier-eslint:

Plugins will be optional. If they are installed and found then they are used. If the plugin is not available then everything should continue without it, and not support the related languages/options added by the plugin.

Let me know if you have any questions!

@Glavin001 Glavin001 added add language good first issue Good for newcomers help wanted Extra attention is needed labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add language enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants