Replies: 1 comment
-
The email-plugin and sms2email-plugin are different because they (currently) depend on site-wide settings taken from |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm not happy with how our plugins are looking. We currently have one type, notification plugins, and soon will have issue system plugins as well. The plan is to support only one issue plugin at a time, but we already support multiple notification plugins.
Loading plugins
One plugin of a specific type at a time
Loading an issue plugin via dotted path is fine, since we plan to support only one at a time.
Many plugins of a specific type at a time
Loading and using multiple notification plugins at the same time can be done in many ways:
If we do something where we do not manually type in what plugins we want via dotted path (like in 3, 4, 5, 6) what do we do with the email-plugin and sms2email-plugin?
Writing plugins
Having an abstract class with static methods is fugly. If there are only static methods, why not import the module, not the class, and have functions instead?
Beta Was this translation helpful? Give feedback.
All reactions