Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic alias for planned maintenance fields #328

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #287.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

To have them match the field names in Zino1
@johannaengland johannaengland added the bug Something isn't working label Jul 29, 2024
@johannaengland johannaengland self-assigned this Jul 29, 2024
@johannaengland johannaengland force-pushed the bugfix/planned-maintenance-field-alias branch from 57b4271 to 40250d8 Compare July 29, 2024 09:21
Copy link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (395ac8e) to head (40250d8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          64       64           
  Lines        7919     7920    +1     
=======================================
+ Hits         7707     7708    +1     
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland merged commit 920b82b into Uninett:master Jul 30, 2024
10 checks passed
@johannaengland johannaengland deleted the bugfix/planned-maintenance-field-alias branch July 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planned maintenance model attributes does not match zino1 attributes
3 participants