Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/alias BGP and Juniper alarm event attributes #352

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Aug 20, 2024

Scope and purpose

Work towards #338. Also mentioned in #331.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (f9fd3fc) to head (e4843d1).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          77       77           
  Lines        9687     9688    +1     
=======================================
+ Hits         9551     9552    +1     
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the rename-bgp-and-juniper-alarm-attributes branch from 3abf97d to e4843d1 Compare August 20, 2024 12:58
Copy link

sonarcloud bot commented Aug 20, 2024

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative, but I would like a team discussion about these renames before we move ahead...

@johannaengland
Copy link
Contributor Author

Nice initiative, but I would like a team discussion about these renames before we move ahead...

I agree! I was thinking I could kick-start such a discussion using this PR 😁

@johannaengland johannaengland merged commit 3078e55 into Uninett:master Aug 21, 2024
10 checks passed
@johannaengland johannaengland deleted the rename-bgp-and-juniper-alarm-attributes branch August 21, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants