-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename/alias BGP and Juniper alarm event attributes #352
Rename/alias BGP and Juniper alarm event attributes #352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 77 77
Lines 9687 9688 +1
=======================================
+ Hits 9551 9552 +1
Misses 136 136 ☔ View full report in Codecov by Sentry. |
3abf97d
to
e4843d1
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice initiative, but I would like a team discussion about these renames before we move ahead...
I agree! I was thinking I could kick-start such a discussion using this PR 😁 |
Scope and purpose
Work towards #338. Also mentioned in #331.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.