fix: partially exclude fot from fee #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I think I want to test it along with Uniswap/smart-order-router#634 before I merge. |
|
looks good - feel free to add an extra test in graphql-token-fee-fetcher.test.ts |
xrsv
approved these changes
Jul 19, 2024
jsy1218
force-pushed
the
siyujiang/route-185-do-new-fot-for-routing-and-fees
branch
from
0ba3858 to
bef5221
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected] |
graphite-app
bot
requested review from
xrsv,
mikeki,
cgkol,
uni-guillaume and
a team
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (07/29/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
cgkol
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In routing-api, we primarily get FOT fee from graphql now. We need to update the graphql schema to include those new boolean flags.
I tested with DFNDR, which has transfer delay. For this token, we make sure the portion related fields are not returned: