Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulkan] Crash if vulkan render plugin is preloaded #42

Open
Meetem opened this issue Apr 4, 2024 · 2 comments
Open

[Vulkan] Crash if vulkan render plugin is preloaded #42

Meetem opened this issue Apr 4, 2024 · 2 comments

Comments

@Meetem
Copy link

Meetem commented Apr 4, 2024

It seems like this line in Hook_vkGetInstanceProcAddr should return vkGetInstanceProcAddr(device, funcName); instead of NULL
Because will NULL return editor is crashing on start, and no initialization is done.

static VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL Hook_vkGetInstanceProcAddr(VkInstance device, const char* funcName)

@Meetem
Copy link
Author

Meetem commented Apr 4, 2024

Also in example plugin it seems like RenderAPI_Vulkan_OnPluginLoad is never called.

@KsGin
Copy link

KsGin commented Aug 9, 2024

this patch will fix it #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants