Skip to content

Commit

Permalink
removed unused PageImages\PageImages imports and moved ExtensionRegis…
Browse files Browse the repository at this point in the history
…try to alphabetical order
  • Loading branch information
domino-1 committed May 23, 2024
1 parent 98087be commit 86a6f37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions includes/Lister/GalleryList.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

namespace MediaWiki\Extension\DynamicPageList3\Lister;

use MediaWiki\Extension\DynamicPageList3\Article;
use PageImages\PageImages;
use ExtensionRegistry;
use MediaWiki\Extension\DynamicPageList3\Article;

class GalleryList extends Lister {
/**
Expand Down Expand Up @@ -60,8 +59,7 @@ public function formatItem( Article $article, $pageText = null ) {
if ( $pageImage ) {
// Successfully got a page image, wrapping it
$item = $this->getItemStart() . $pageImage . '| [[' . $item . ']]' . $this->itemEnd . 'link=' . $item;
}
else {
} else {

Check warning

Code scanning / Phpmd (reported by Codacy)

Use return statements instead of else expression Warning

The method formatItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
// Failed to get a page image
$item = $this->getItemStart() . $item . $this->itemEnd . '[[' . $item . ']]';
}
Expand Down
3 changes: 1 addition & 2 deletions includes/Lister/Lister.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@

namespace MediaWiki\Extension\DynamicPageList3\Lister;

use ExtensionRegistry;
use MediaWiki\Extension\DynamicPageList3\Article;
use MediaWiki\Extension\DynamicPageList3\LST;
use MediaWiki\Extension\DynamicPageList3\Parameters;
use MediaWiki\Extension\DynamicPageList3\UpdateArticle;
use MediaWiki\MediaWikiServices;
use PageImages\PageImages;
use ExtensionRegistry;
use Parser;
use RequestContext;
use Sanitizer;
Expand Down

0 comments on commit 86a6f37

Please sign in to comment.