-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numbered wars #44
Comments
Example 2 and 3 are ordinal number words, so should be IIRC, NNP is used in the XPOS for compatibility with PTB. In this case, example 3 should match example 2. This gives a conflicting XPOS candidate (CD or NNP). The cambridge dictionary classifies the ordinals as determiners (but notes that another determiner like "the" or "a" can preceed the ordinal): However, wiktionary classifies them as adjectives: Wikipedia doesn't mention ordinals as adjectives in the adjective order page: But Wikipedia seems to agree with the Cambridge dictionary and not wiktionary on that page:
|
Ordinal numbers should be ADJ: https://universaldependencies.org/u/pos/ADJ.html |
So |
My hunch is NNP |
|
In "World War I", definitely "World" and "War" are NNP. I would lean that way also for "First World War", and that seems to be consistent with OntoNotes. |
Worth pointing out that in GUM, the 2002 World Cup gets the tag CD (not NNP). However, it might be considered not actually part of the name, I suppose. |
... although they later annotate
with |
How do the changes here look? |
LGTM |
I think that's canon, let me know if someone wants to argue it's not? |
It seems weird that we have
but then also have
and
The text was updated successfully, but these errors were encountered: