Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Giving feedback is SLOW #1463

Open
Veikkosuhonen opened this issue Jan 30, 2025 · 1 comment
Open

[PERF] Giving feedback is SLOW #1463

Veikkosuhonen opened this issue Jan 30, 2025 · 1 comment
Assignees
@Veikkosuhonen
Labels
optimisation Programmers need to make everything blazingly fast

Comments

@Veikkosuhonen
Copy link
Member

Veikkosuhonen commented Jan 30, 2025 •
edited
Loading

Related to #1227 .

#1428 introduced new db queries that end up being very slow in production.

POST /api/feedbacks took over 5 seconds in this example.

Since the UI doesn't have a loading indicator, this is too slow

Image

PUT /api/feedbacks took 100 ms. Investigate why POST is slow.
@Veikkosuhonen Veikkosuhonen added the optimisation Programmers need to make everything blazingly fast label Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Wishlist in Norppa Backlog Jan 30, 2025
@Veikkosuhonen Veikkosuhonen moved this from Wishlist to New in Norppa Backlog Jan 30, 2025
@Veikkosuhonen Veikkosuhonen self-assigned this Jan 30, 2025
@Veikkosuhonen Veikkosuhonen moved this from New to In progress in Norppa Backlog Jan 30, 2025
Veikkosuhonen added a commit that referenced this issue Jan 30, 2025
@Veikkosuhonen
fix: Unnecessary slow db query in updateSummaryOnFeedback (#1463)
ac783e6
@Veikkosuhonen
Copy link
Member Author

Seems to be fixed with release made around 12.50

Image

@Veikkosuhonen Veikkosuhonen moved this from In progress to Ready for review in Norppa Backlog Jan 31, 2025
@Veikkosuhonen Veikkosuhonen moved this from Ready for review to Waiting for QA in Norppa Backlog Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veikkosuhonen Veikkosuhonen

Labels
optimisation Programmers need to make everything blazingly fast
Projects
Norppa Backlog
Status: Waiting for QA
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Veikkosuhonen