Skip to content

Commit

Permalink
feat: search order by final (#6976)
Browse files Browse the repository at this point in the history
Final rank has always been ordering correctly by default. But after 5.12
I see some issues that sometimes it is not ordered. Just to be extra
sure, I am for ordering it.
  • Loading branch information
sjaanus authored May 3, 2024
1 parent bd0cd01 commit 2c05f1a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/lib/features/feature-search/feature-search-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,8 @@ class FeatureSearchStore implements IFeatureSearchStore {
);
})
.joinRaw('CROSS JOIN total_features')
.whereBetween('final_rank', [offset + 1, offset + limit]);
.whereBetween('final_rank', [offset + 1, offset + limit])
.orderBy('final_rank');
const rows = await finalQuery;
stopTimer();
if (rows.length > 0) {
Expand Down

0 comments on commit 2c05f1a

Please sign in to comment.