Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text overflow on project users access page #8853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: text overflow on project users access page #8853

wants to merge 1 commit into from

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Nov 25, 2024

Remove scrollbar in project settings - user roles

before:
image

after:
image

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 5:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 5:11pm

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

}

export const TooltipLink = ({
tooltip,
highlighted,
tooltipProps,
children,
clampText,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be configurable? when do we want ellipsis vs scrollbar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question 🙋🏼 But also: is it okay that we don't show the whole text. should we reconfigure the tables instead? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this component in many other places, mostly but not only in tables. I think it's not always in a place constrained by column width.

textDecorationStyle: 'dashed',
textUnderlineOffset: theme.spacing(0.5),
whiteSpace: 'nowrap',
...(clampText
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was clamp I though we gonna use css clamp so maybe we should pick a term that doesn't have other meaning in CSS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overflowEllipsis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have many examples of Truncate/Truncated in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants