From 2800085e53452fd486dc679cd97973c5ed9b4ee1 Mon Sep 17 00:00:00 2001 From: UnlikePaladin <36827970+UnlikePaladin@users.noreply.github.com> Date: Mon, 1 Jan 2024 19:45:24 -0600 Subject: [PATCH] fix missing particles on ladder blocks --- .../pfm/models/block/simple_bunk_ladder/simple_ladder.json | 4 ++-- .../models/block/simple_bunk_ladder/simple_ladder_top.json | 4 ++-- .../pfm/blocks/models/ladder/forge/ForgeLadderModel.java | 7 +++++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder.json b/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder.json index 5ea44ba92..eae66e1c5 100644 --- a/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder.json +++ b/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder.json @@ -1,8 +1,8 @@ { "credit": "By UnlikePaladin", "textures": { - "0": "#texture", - "particle": "#texture" + "0": "minecraft:block/oak_planks", + "particle": "minecraft:block/oak_planks" }, "elements": [ { diff --git a/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder_top.json b/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder_top.json index 7fdddeb82..9c4bbf5b9 100644 --- a/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder_top.json +++ b/common/src/main/resources/assets/pfm/models/block/simple_bunk_ladder/simple_ladder_top.json @@ -1,8 +1,8 @@ { "credit": "By UnlikePaladin", "textures": { - "0": "#texture", - "particle": "#texture" + "0": "minecraft:block/oak_planks", + "particle": "minecraft:block/oak_planks" }, "elements": [ { diff --git a/forge/src/main/java/com/unlikepaladin/pfm/blocks/models/ladder/forge/ForgeLadderModel.java b/forge/src/main/java/com/unlikepaladin/pfm/blocks/models/ladder/forge/ForgeLadderModel.java index 59fca0f69..523cfefa9 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/blocks/models/ladder/forge/ForgeLadderModel.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/blocks/models/ladder/forge/ForgeLadderModel.java @@ -8,8 +8,11 @@ import net.minecraft.client.render.model.ModelBakeSettings; import net.minecraft.client.texture.Sprite; import net.minecraft.item.ItemStack; +import net.minecraft.util.math.BlockPos; import net.minecraft.util.math.Direction; +import net.minecraft.world.BlockRenderView; import net.minecraftforge.client.model.data.IModelData; +import net.minecraftforge.client.model.data.ModelDataMap; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -35,6 +38,10 @@ public List getQuads(@Nullable BlockState state, @Nullable Direction return Collections.emptyList(); } + @Override + public @NotNull IModelData getModelData(@NotNull BlockRenderView world, @NotNull BlockPos pos, @NotNull BlockState state, @NotNull IModelData tileData) { + return super.getModelData(world, pos, state, new ModelDataMap.Builder().build()); + } @Override public List getQuads(ItemStack stack, @Nullable BlockState state, @Nullable Direction face, Random random) {