diff --git a/common/src/main/java/com/unlikepaladin/pfm/blocks/BasicChairBlock.java b/common/src/main/java/com/unlikepaladin/pfm/blocks/BasicChairBlock.java index 374a64379..734eca7ae 100644 --- a/common/src/main/java/com/unlikepaladin/pfm/blocks/BasicChairBlock.java +++ b/common/src/main/java/com/unlikepaladin/pfm/blocks/BasicChairBlock.java @@ -1,7 +1,7 @@ package com.unlikepaladin.pfm.blocks; import com.unlikepaladin.pfm.data.FurnitureBlock; -import com.unlikepaladin.pfm.data.Tags; +import com.unlikepaladin.pfm.data.PFMTags; import net.minecraft.block.Block; import net.minecraft.block.BlockState; import net.minecraft.block.Material; @@ -128,7 +128,7 @@ public BlockState getStateForNeighborUpdate(BlockState state, Direction directio } public boolean canTuck(BlockState state) { - return state.isIn(Tags.getTuckableBlocks()); + return state.isIn(PFMTags.TUCKABLE_BLOCKS); } @Override diff --git a/common/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/PFMFarmersDelight.java b/common/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/PFMFarmersDelight.java index 5c6a4f856..fbd6f7b52 100644 --- a/common/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/PFMFarmersDelight.java +++ b/common/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/PFMFarmersDelight.java @@ -1,11 +1,17 @@ package com.unlikepaladin.pfm.compat.farmersdelight; import com.unlikepaladin.pfm.compat.PFMModCompatibility; +import com.unlikepaladin.pfm.data.PFMTags; import dev.architectury.injectables.annotations.ExpectPlatform; +import net.minecraft.block.Block; +import net.minecraft.tag.TagKey; +import net.minecraft.util.Identifier; public abstract class PFMFarmersDelight implements PFMModCompatibility { @ExpectPlatform public static PFMFarmersDelight getInstance() { throw new AssertionError(); }; + + protected static final TagKey HEAT_SOURCES = PFMTags.createTag(new Identifier("farmersdelight", "heat_sources")); } diff --git a/common/src/main/java/com/unlikepaladin/pfm/data/PFMTags.java b/common/src/main/java/com/unlikepaladin/pfm/data/PFMTags.java new file mode 100644 index 000000000..8aabf7844 --- /dev/null +++ b/common/src/main/java/com/unlikepaladin/pfm/data/PFMTags.java @@ -0,0 +1,15 @@ +package com.unlikepaladin.pfm.data; + +import dev.architectury.injectables.annotations.ExpectPlatform; +import net.minecraft.block.Block; +import net.minecraft.tag.TagKey; +import net.minecraft.util.Identifier; + +public class PFMTags { + public static TagKey TUCKABLE_BLOCKS = createTag(new Identifier("pfm", "tuckable_blocks")); + + @ExpectPlatform + public static TagKey createTag(Identifier identifier) { + throw new AssertionError(); + } +} diff --git a/common/src/main/java/com/unlikepaladin/pfm/data/Tags.java b/common/src/main/java/com/unlikepaladin/pfm/data/Tags.java deleted file mode 100644 index 6df2f8a46..000000000 --- a/common/src/main/java/com/unlikepaladin/pfm/data/Tags.java +++ /dev/null @@ -1,13 +0,0 @@ -package com.unlikepaladin.pfm.data; - -import dev.architectury.injectables.annotations.ExpectPlatform; -import net.minecraft.block.Block; -import net.minecraft.tag.TagKey; - -public class Tags { - - @ExpectPlatform - public static TagKey getTuckableBlocks() { - throw new AssertionError("Failed to get Tag"); - } -} diff --git a/common/src/main/java/com/unlikepaladin/pfm/runtime/data/PFMTagProvider.java b/common/src/main/java/com/unlikepaladin/pfm/runtime/data/PFMTagProvider.java index aea0aed41..18193f66a 100644 --- a/common/src/main/java/com/unlikepaladin/pfm/runtime/data/PFMTagProvider.java +++ b/common/src/main/java/com/unlikepaladin/pfm/runtime/data/PFMTagProvider.java @@ -8,7 +8,7 @@ import com.unlikepaladin.pfm.blocks.*; import com.unlikepaladin.pfm.compat.PFMModCompatibility; import com.unlikepaladin.pfm.data.FurnitureBlock; -import com.unlikepaladin.pfm.data.Tags; +import com.unlikepaladin.pfm.data.PFMTags; import com.unlikepaladin.pfm.registry.PaladinFurnitureModBlocksItems; import com.unlikepaladin.pfm.runtime.PFMDataGen; import com.unlikepaladin.pfm.runtime.PFMRuntimeResources; @@ -199,7 +199,7 @@ protected void generateTags() { getOrCreateTagBuilder(BlockTags.CLIMBABLE) .add(simpleBunkLadders); - getOrCreateTagBuilder(Tags.getTuckableBlocks()) + getOrCreateTagBuilder(PFMTags.TUCKABLE_BLOCKS) .add(woodBasicTables) .add(stoneBasicTables) .add(woodClassicTables) diff --git a/common/src/main/resources/pfm_background.png b/common/src/main/resources/pfm_background.png new file mode 100644 index 000000000..a7cecd27c Binary files /dev/null and b/common/src/main/resources/pfm_background.png differ diff --git a/fabric/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/fabric/PFMFarmersDelightImpl.java b/fabric/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/fabric/PFMFarmersDelightImpl.java index 9aa6764ea..0b153d76c 100644 --- a/fabric/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/fabric/PFMFarmersDelightImpl.java +++ b/fabric/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/fabric/PFMFarmersDelightImpl.java @@ -26,7 +26,7 @@ public void generateTags() { List stoves = new ArrayList<>(StoveBlock.streamStoves().map(FurnitureBlock::getBlock).toList()); stoves.addAll(IronStoveBlock.streamIronStoves().map(FurnitureBlock::getBlock).toList()); stoves.add(PaladinFurnitureModBlocksItems.KITCHEN_STOVETOP); - PFMTagProvider.getOrCreateTagBuilder(TagsRegistry.HEAT_SOURCES) + PFMTagProvider.getOrCreateTagBuilder(HEAT_SOURCES) .add(stoves.toArray(new Block[0])); } diff --git a/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PFMTagsImpl.java b/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PFMTagsImpl.java new file mode 100644 index 000000000..c254b842a --- /dev/null +++ b/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PFMTagsImpl.java @@ -0,0 +1,12 @@ +package com.unlikepaladin.pfm.data.fabric; + +import net.minecraft.block.Block; +import net.minecraft.tag.TagKey; +import net.minecraft.util.Identifier; +import net.minecraft.util.registry.Registry; + +public class PFMTagsImpl { + public static TagKey createTag(Identifier identifier) { + return TagKey.of(Registry.BLOCK_KEY, identifier); + } +} diff --git a/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PaladinFurnitureModDataEntrypoint.java b/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PaladinFurnitureModDataEntrypoint.java index 966a23409..43d08230a 100644 --- a/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PaladinFurnitureModDataEntrypoint.java +++ b/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/PaladinFurnitureModDataEntrypoint.java @@ -3,7 +3,6 @@ import com.unlikepaladin.pfm.blocks.DinnerChairBlock; import com.unlikepaladin.pfm.blocks.*; import com.unlikepaladin.pfm.data.FurnitureBlock; -import com.unlikepaladin.pfm.data.Tags; import com.unlikepaladin.pfm.registry.PaladinFurnitureModBlocksItems; import com.unlikepaladin.pfm.runtime.data.FurnitureRecipeJsonFactory; import net.fabricmc.fabric.api.datagen.v1.DataGeneratorEntrypoint; diff --git a/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/TagsImpl.java b/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/TagsImpl.java deleted file mode 100644 index 8005bf45a..000000000 --- a/fabric/src/main/java/com/unlikepaladin/pfm/data/fabric/TagsImpl.java +++ /dev/null @@ -1,15 +0,0 @@ -package com.unlikepaladin.pfm.data.fabric; - -import net.minecraft.block.Block; -import net.minecraft.tag.TagKey; -import net.minecraft.util.Identifier; -import net.minecraft.util.registry.Registry; - -public class TagsImpl { - - public static TagKey TUCKABLE_BLOCKS = TagKey.of(Registry.BLOCK_KEY, new Identifier("pfm", "tuckable_blocks")); - - public static TagKey getTuckableBlocks() { - return TUCKABLE_BLOCKS; - } -} diff --git a/fabric/src/main/resources/fabric.mod.json b/fabric/src/main/resources/fabric.mod.json index da3a37535..8d42f2d68 100755 --- a/fabric/src/main/resources/fabric.mod.json +++ b/fabric/src/main/resources/fabric.mod.json @@ -9,7 +9,8 @@ ], "contact": { "homepage": "https://www.curseforge.com/minecraft/mc-mods/paladins-furniture", - "sources": "https://github.com/UnlikePaladin/paladins-furniture" + "sources": "https://github.com/UnlikePaladin/paladins-furniture", + "issues": "https://github.com/UnlikePaladin/paladins-furniture/issues" }, "contributors": [ "lzyzl6", @@ -52,5 +53,12 @@ }, "suggests": { "patchouli": "*" + }, + "modmenu": { + "links": { + "modmenu.discord": "https://discord.gg/zbMDUPB", + "modmenu.kofi": "https://ko-fi.com/unlikepaladin", + "modmenu.modrinth": "https://modrinth.com/mod/paladins-furniture/" + } } } \ No newline at end of file diff --git a/forge/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/forge/PFMFarmersDelightImpl.java b/forge/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/forge/PFMFarmersDelightImpl.java index ae5e9f975..04023785b 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/forge/PFMFarmersDelightImpl.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/compat/farmersdelight/forge/PFMFarmersDelightImpl.java @@ -26,7 +26,7 @@ public void generateTags() { List stoves = new ArrayList<>(StoveBlock.streamStoves().map(FurnitureBlock::getBlock).toList()); stoves.addAll(IronStoveBlock.streamIronStoves().map(FurnitureBlock::getBlock).toList()); stoves.add(PaladinFurnitureModBlocksItems.KITCHEN_STOVETOP); - PFMTagProvider.getOrCreateTagBuilder(ModTags.HEAT_SOURCES) + PFMTagProvider.getOrCreateTagBuilder(HEAT_SOURCES) .add(stoves.toArray(new Block[0])); } diff --git a/forge/src/main/java/com/unlikepaladin/pfm/data/forge/TagsImpl.java b/forge/src/main/java/com/unlikepaladin/pfm/data/forge/PFMTagsImpl.java similarity index 53% rename from forge/src/main/java/com/unlikepaladin/pfm/data/forge/TagsImpl.java rename to forge/src/main/java/com/unlikepaladin/pfm/data/forge/PFMTagsImpl.java index 52770b3df..0dec027fd 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/data/forge/TagsImpl.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/data/forge/PFMTagsImpl.java @@ -5,10 +5,8 @@ import net.minecraft.tag.TagKey; import net.minecraft.util.Identifier; -public class TagsImpl { - public static TagKey TUCKABLE_BLOCKS; - - public static TagKey getTuckableBlocks() { - return TUCKABLE_BLOCKS; +public class PFMTagsImpl { + public static TagKey createTag(Identifier identifier) { + return BlockTags.create(new Identifier("pfm", "tuckable_blocks")); } } diff --git a/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java b/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java index 9ea3281b1..21634e008 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java @@ -2,8 +2,7 @@ import com.unlikepaladin.pfm.PaladinFurnitureMod; import com.unlikepaladin.pfm.config.PaladinFurnitureModConfig; -import com.unlikepaladin.pfm.data.forge.TagsImpl; -import com.unlikepaladin.pfm.registry.BlockItemRegistry; +import com.unlikepaladin.pfm.data.forge.PFMTagsImpl; import com.unlikepaladin.pfm.registry.dynamic.forge.LateBlockRegistryForge; import com.unlikepaladin.pfm.registry.forge.*; import net.minecraft.tag.BlockTags; @@ -29,7 +28,6 @@ public PaladinFurnitureModForge() { GENERAL_LOGGER.error("", e); } ItemGroupRegistryForge.registerItemGroups(); - TagsImpl.TUCKABLE_BLOCKS = BlockTags.create(new Identifier("pfm", "tuckable_blocks")); MinecraftForge.EVENT_BUS.register(EntityRegistryForge.class); MinecraftForge.EVENT_BUS.register(BlockItemRegistryForge.class); MinecraftForge.EVENT_BUS.register(StatisticsRegistryForge.class); diff --git a/forge/src/main/resources/META-INF/mods.toml b/forge/src/main/resources/META-INF/mods.toml index 37cf13b9e..14386728b 100755 --- a/forge/src/main/resources/META-INF/mods.toml +++ b/forge/src/main/resources/META-INF/mods.toml @@ -11,6 +11,7 @@ authors = "UnlikePaladin" description = ''' A Brand-New Furniture mod for Modern Minecraft where things are functional! ''' +itemIcon = "pfm:oak_chair" logoFile = "icon.png" credits = "Translators: lzyzl6, MIHONO, WrenXing" @@ -26,4 +27,8 @@ modId = "minecraft" mandatory = true versionRange = "[1.19,1.19.3)" ordering = "NONE" -side = "BOTH" \ No newline at end of file +side = "BOTH" + +[modproperties.pfm] +catalogueBackground="pfm_background.png" +catalogueImageIcon="" \ No newline at end of file diff --git a/gradle.properties b/gradle.properties index 4291d5c8f..e675fd782 100755 --- a/gradle.properties +++ b/gradle.properties @@ -4,7 +4,7 @@ minecraft_version=1.19 enabled_platforms=fabric,forge archives_base_name=paladin-furniture-mod -mod_version=1.2.0 +mod_version=1.2.0-rc2 maven_group=com.unlikepaladin architectury_version=5.12.42