From 9fce57a2c6aec7404850ca6653e941a996ef92e3 Mon Sep 17 00:00:00 2001 From: UnlikePaladin <36827970+UnlikePaladin@users.noreply.github.com> Date: Wed, 30 Aug 2023 12:00:56 -0600 Subject: [PATCH] Fix potential issues with mod compatibility running too late Remove Outdated Comments Bumped to RC3 --- .../com/unlikepaladin/pfm/runtime/assets/PFMLangProvider.java | 2 -- .../com/unlikepaladin/pfm/fabric/PaladinFurnitureModFabric.java | 2 +- .../cookingforblockheads/forge/FridgeBlockEntityBalm.java | 1 - .../com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java | 2 +- gradle.properties | 2 +- 5 files changed, 3 insertions(+), 6 deletions(-) diff --git a/common/src/main/java/com/unlikepaladin/pfm/runtime/assets/PFMLangProvider.java b/common/src/main/java/com/unlikepaladin/pfm/runtime/assets/PFMLangProvider.java index 9899b3c65..72735cef1 100644 --- a/common/src/main/java/com/unlikepaladin/pfm/runtime/assets/PFMLangProvider.java +++ b/common/src/main/java/com/unlikepaladin/pfm/runtime/assets/PFMLangProvider.java @@ -201,8 +201,6 @@ public static String translate(String key, Object ... args) { } } - //TODO: check if the mod version's different and regen assets - //TODO: Waterlog chairs and tables only public void generateTranslationForLampBlock(BufferedWriter writer) { for (WoodVariant variant : WoodVariantRegistry.getVariants()) { for (DyeColor color : DyeColor.values()) { diff --git a/fabric/src/main/java/com/unlikepaladin/pfm/fabric/PaladinFurnitureModFabric.java b/fabric/src/main/java/com/unlikepaladin/pfm/fabric/PaladinFurnitureModFabric.java index 36dbc0cad..76dabfd1a 100644 --- a/fabric/src/main/java/com/unlikepaladin/pfm/fabric/PaladinFurnitureModFabric.java +++ b/fabric/src/main/java/com/unlikepaladin/pfm/fabric/PaladinFurnitureModFabric.java @@ -61,6 +61,7 @@ public void onInitialize() { GENERAL_LOGGER.error("Failed to initialize Paladin's Furniture configuration, default values will be used instead"); GENERAL_LOGGER.error("", e); } + this.commonInit(); PaladinFurnitureMod.DYE_KITS = FabricItemGroupBuilder.create( new Identifier(MOD_ID, "dye_kits")) @@ -89,7 +90,6 @@ public void onInitialize() { PaladinFurnitureModFabric.initializeItemGroup(); BlockItemRegistryFabric.registerItems(); BlockItemRegistryFabric.registerBlocks(); - this.commonInit(); //PFMRuntimeResources.prepareAsyncResourceGen(); No async gen because Forge won't behave, blame it. PFMRuntimeResources.ready = true; StatisticsRegistryFabric.registerStatistics(); diff --git a/forge/src/main/java/com/unlikepaladin/pfm/compat/cookingforblockheads/forge/FridgeBlockEntityBalm.java b/forge/src/main/java/com/unlikepaladin/pfm/compat/cookingforblockheads/forge/FridgeBlockEntityBalm.java index 69cd7d5c1..4d7c1b121 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/compat/cookingforblockheads/forge/FridgeBlockEntityBalm.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/compat/cookingforblockheads/forge/FridgeBlockEntityBalm.java @@ -34,7 +34,6 @@ import java.util.*; -//TODO: oven and freezer support, make the freezer always provide ice, custom crafting counter public class FridgeBlockEntityBalm extends FridgeBlockEntity implements BalmContainerProvider, BalmProviderHolder, BalmBlockEntityContract { private final DefaultKitchenItemProvider itemProvider; diff --git a/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java b/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java index 22f6c0d12..70e24e532 100644 --- a/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java +++ b/forge/src/main/java/com/unlikepaladin/pfm/forge/PaladinFurnitureModForge.java @@ -29,6 +29,7 @@ public PaladinFurnitureModForge() { GENERAL_LOGGER.error("Failed to initialize Paladin's Furniture configuration, default values will be used instead"); GENERAL_LOGGER.error("", e); } + this.commonInit(); ItemGroupRegistryForge.registerItemGroups(); MinecraftForge.EVENT_BUS.register(EntityRegistryForge.class); MinecraftForge.EVENT_BUS.register(BlockItemRegistryForge.class); @@ -41,7 +42,6 @@ public PaladinFurnitureModForge() { NetworkRegistryForge.registerPackets(); LateBlockRegistryForge.addDynamicBlockRegistration(Block.class); LateBlockRegistryForge.addDynamicBlockRegistration(Item.class); - this.commonInit(); PaladinFurnitureMod.isClient = FMLEnvironment.dist == Dist.CLIENT; } } diff --git a/gradle.properties b/gradle.properties index 7b079ce7f..898f86b82 100755 --- a/gradle.properties +++ b/gradle.properties @@ -4,7 +4,7 @@ minecraft_version=1.17.1 enabled_platforms=fabric,forge archives_base_name=paladin-furniture-mod -mod_version=1.2.0 +mod_version=1.2.0-rc3 maven_group=com.unlikepaladin architectury_version=2.10.12