Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Annotate UserAdditionalInfo model #172

Closed
7 tasks
choden-dev opened this issue Mar 20, 2024 · 0 comments · Fixed by #199
Closed
7 tasks

[BACKEND] Annotate UserAdditionalInfo model #172

choden-dev opened this issue Mar 20, 2024 · 0 comments · Fixed by #199
Assignees
Labels
backend relating to code in the /server directory good first issue Good for newcomers tech debt Technical debt needing to be fixed

Comments

@choden-dev
Copy link
Member

Is your feature request related to a problem? Please describe.
We should annotate our DTOs (data transfer object) so that they can be validated.

Describe the solution you'd like

Check out the examples at https://tsoa-community.github.io/docs/annotations.html and look at the firebase architecture page

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

BEFORE MERGING

  • Integration test written for services
  • Code generation run (hint: yarn workspace server tsoa spec-and-routes)
  • Schemas annotated if adding new models
  • Appropriate mocks created where possible
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added backend relating to code in the /server directory frontend relating to code in the /client directory labels Mar 20, 2024
@choden-dev choden-dev changed the title [BACKEND] Annotate UserAdditionalInfo model in firebase [BACKEND] Annotate UserAdditionalInfo model Mar 20, 2024
@choden-dev choden-dev added good first issue Good for newcomers tech debt Technical debt needing to be fixed and removed frontend relating to code in the /client directory labels Mar 20, 2024
@Kartik-M24 Kartik-M24 self-assigned this Mar 24, 2024
@Kartik-M24 Kartik-M24 linked a pull request Mar 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend relating to code in the /server directory good first issue Good for newcomers tech debt Technical debt needing to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants