Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Setup endpoint to sign up a user #188

Closed
7 tasks
choden-dev opened this issue Mar 27, 2024 · 0 comments · Fixed by #297
Closed
7 tasks

[BACKEND] Setup endpoint to sign up a user #188

choden-dev opened this issue Mar 27, 2024 · 0 comments · Fixed by #297
Assignees
Labels
backend relating to code in the /server directory

Comments

@choden-dev
Copy link
Member

choden-dev commented Mar 27, 2024

Is your feature request related to a problem? Please describe.
We need a route /signup so that users get an account after providing the required details
blocked by #137
blocked by #192

Describe the solution you'd like
Make use of the UserService and AuthService to create an document in the users collection as well as using the auth service to give them an account. We should return a JWT token for the newly created user that can be used with signInWithCustomToken on the front end

BEFORE MERGING

  • Integration test written for services
  • Schemas annotated if adding new models
  • Code generation run (hint: yarn workspace server tsoa spec-and-routes)
  • Appropriate mocks created where possible
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the backend relating to code in the /server directory label Mar 27, 2024
@choden-dev choden-dev added this to the Club sign-up functionality milestone Mar 29, 2024
@jeffplays2005 jeffplays2005 self-assigned this Mar 31, 2024
@jeffplays2005 jeffplays2005 linked a pull request Apr 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend relating to code in the /server directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants