Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Create exit confirmation dialog #244

Open
6 tasks
choden-dev opened this issue Apr 9, 2024 · 0 comments
Open
6 tasks

[FRONTEND] Create exit confirmation dialog #244

choden-dev opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
frontend relating to code in the /client directory

Comments

@choden-dev
Copy link
Member

Is your feature request related to a problem? Please describe.
Note you should aim to create a generic modal component first.

The exit form should also be decoupled from any logic so it can be tested

Image

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the frontend relating to code in the /client directory label Apr 9, 2024
@choden-dev choden-dev changed the title [FRONTEND] Create exit confirmation [FRONTEND] Create exit confirmation dialog Apr 11, 2024
@Kunalbskr Kunalbskr self-assigned this Apr 11, 2024
@choden-dev choden-dev added this to the Club sign-up functionality milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend relating to code in the /client directory
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants