Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Create generic information panel #327

Open
6 tasks
choden-dev opened this issue May 3, 2024 · 0 comments · Fixed by #354
Open
6 tasks

[FRONTEND] Create generic information panel #327

choden-dev opened this issue May 3, 2024 · 0 comments · Fixed by #354
Assignees
Labels
frontend relating to code in the /client directory

Comments

@choden-dev
Copy link
Member

choden-dev commented May 3, 2024

Is your feature request related to a problem? Please describe.

Image

Image

Image

Only focus on making the container with the title & edit button (ignore the internals). It should be able to take in any children like normal react nodes by having a prop of type ReactNode.

This should ONLY be concerned with presentation.

Make sure we have a prop like onEdit so the consumer can use whatever handler, if no handler is provided, we should hide the edit icon

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the frontend relating to code in the /client directory label May 3, 2024
@choden-dev choden-dev changed the title [FRONTEND] Create additional info panel [FRONTEND] Create info panel May 5, 2024
@choden-dev choden-dev changed the title [FRONTEND] Create info panel [FRONTEND] Create generic information panel May 5, 2024
@jeffplays2005 jeffplays2005 linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend relating to code in the /client directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants