Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Make profile page personal information 2 columns on small screen #365

Closed
6 tasks
choden-dev opened this issue May 21, 2024 · 0 comments · Fixed by #437
Closed
6 tasks

[FRONTEND] Make profile page personal information 2 columns on small screen #365

choden-dev opened this issue May 21, 2024 · 0 comments · Fixed by #437
Labels
frontend relating to code in the /client directory good first issue Good for newcomers tech debt Technical debt needing to be fixed

Comments

@choden-dev
Copy link
Member

Is your feature request related to a problem? Please describe.

When #360 was merged, did not fully check small screen responsiveness.

What it looks like:

Image

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added frontend relating to code in the /client directory good first issue Good for newcomers tech debt Technical debt needing to be fixed labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend relating to code in the /client directory good first issue Good for newcomers tech debt Technical debt needing to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant