Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND] Add UASC team to about page #625

Closed
6 tasks
choden-dev opened this issue Jul 13, 2024 · 0 comments · Fixed by #742
Closed
6 tasks

[FRONTEND] Add UASC team to about page #625

choden-dev opened this issue Jul 13, 2024 · 0 comments · Fixed by #742
Assignees
@AzizPatel786
Labels
frontend relating to code in the /client directory HARD recommended for experts
Milestone
Exec Page

Comments

@choden-dev
Copy link
Member

choden-dev commented Jul 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Blocked by #650

Image

You will need to define schemas https://www.sanity.io/learn/course/day-one-with-sanity-studio/creating-a-schema and fetch them statically in the page - there needs to be the following ones:

  • Committee members
  • Life members

https://github.com/UoaWDCC/uasc-web/wiki/Sanity-Studio-Development

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the frontend relating to code in the /client directory label Jul 13, 2024
@choden-dev choden-dev added this to the Exec Page milestone Jul 19, 2024
@choden-dev choden-dev changed the title [FRONTEND] Create exec team page [FRONTEND] Add UASC team to about page Jul 20, 2024
@choden-dev choden-dev added the HARD recommended for experts label Jul 20, 2024
@AzizPatel786 AzizPatel786 self-assigned this Jul 24, 2024
@AzizPatel786 AzizPatel786 linked a pull request Aug 5, 2024 that will close this issue
625 add team to about #742
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzizPatel786 AzizPatel786

Labels
frontend relating to code in the /client directory HARD recommended for experts
Projects
None yet
Milestone
Exec Page
Development

Successfully merging a pull request may close this issue.

625 add team to about UoaWDCC/uasc-web
2 participants
@AzizPatel786 @choden-dev