Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRONTEND] Set up schema for photo gallery on front end #663

Closed
6 tasks
choden-dev opened this issue Jul 20, 2024 · 0 comments · Fixed by #714
Closed
6 tasks

[FRONTEND] Set up schema for photo gallery on front end #663

choden-dev opened this issue Jul 20, 2024 · 0 comments · Fixed by #714
Assignees
Labels
frontend relating to code in the /client directory
Milestone

Comments

@choden-dev
Copy link
Member

choden-dev commented Jul 20, 2024

Is your feature request related to a problem? Please describe.

We want all the content of the gallery to be changeable through a CMS rather than requiring changing the code.

Note that admins may want to display images based on:

  • year
  • event
  • other tags

The example at https://github.com/UoaWDCC/uasc-web/wiki/Sanity-Studio-Development may be helpful

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the frontend relating to code in the /client directory label Jul 20, 2024
@choden-dev choden-dev added this to the Photo Gallery milestone Jul 20, 2024
@tmacsmee tmacsmee self-assigned this Jul 26, 2024
@tmacsmee tmacsmee linked a pull request Jul 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend relating to code in the /client directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants