Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Delete all code relating to event sign ups #797

Closed
7 tasks
choden-dev opened this issue Oct 5, 2024 · 0 comments · Fixed by #800
Closed
7 tasks

[BACKEND] Delete all code relating to event sign ups #797

choden-dev opened this issue Oct 5, 2024 · 0 comments · Fixed by #800
Assignees
Labels
backend relating to code in the /server directory

Comments

@choden-dev
Copy link
Member

choden-dev commented Oct 5, 2024

Is your feature request related to a problem? Please describe.

You will have to change:

  • server\src\data-layer\models\firebase.ts
  • server\src\service-layer\controllers\EventController.ts
  • FirestoreCollections

BEFORE MERGING

  • Integration test written for services
  • Schemas annotated if adding new models
  • Code generation run (hint: yarn workspace server tsoa spec-and-routes)
  • Appropriate mocks created where possible
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the backend relating to code in the /server directory label Oct 5, 2024
@jeffplays2005 jeffplays2005 self-assigned this Oct 6, 2024
@jeffplays2005 jeffplays2005 linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend relating to code in the /server directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants