Skip to content

Commit

Permalink
fix: modify docker-compose file to have proper docker image tag
Browse files Browse the repository at this point in the history
  • Loading branch information
gerbie-goober committed Aug 4, 2024
1 parent bc93046 commit 017f962
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/A2_Part1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,8 @@ jobs:
- name: Build the Docker images
run: docker-compose build

- name: Tag and push the Docker images
- name: Push the Docker images
run: |
docker tag cscc01-linkup_frontend:latest ${{ secrets.DOCKERHUB_USERNAME }}/cscc01-linkup_frontend:latest
docker tag cscc01-linkup_backend:latest ${{ secrets.DOCKERHUB_USERNAME }}/cscc01-linkup_backend:latest
docker push ${{ secrets.DOCKERHUB_USERNAME }}/cscc01-linkup_frontend:latest
docker push ${{ secrets.DOCKERHUB_USERNAME }}/cscc01-linkup_backend:latest
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ services: # Start with this tag. This will contain all the containers you want t
context: ./frontend # Path to the Dockerfile
dockerfile: Dockerfile # Name of the Dockerfile
container_name: frontend
image: cscc01-linkup_frontend:latest
ports:
- '80:3000'
restart: always
Expand All @@ -20,6 +21,7 @@ services: # Start with this tag. This will contain all the containers you want t
context: ./backend
dockerfile: Dockerfile
container_name: backend
image: cscc01-linkup_backend:latest
environment: # Environment variables to be passed to the container
MONGODB_URI: "mongodb+srv://Cluster20901:[email protected]/linkup?retryWrites=true&w=majority&appName=Cluster20901"
ports:
Expand Down

0 comments on commit 017f962

Please sign in to comment.