Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pre-commit skip man/ folder (docs generated by roxygen) #32

Closed
apulsipher opened this issue Nov 4, 2024 · 2 comments
Closed

Make pre-commit skip man/ folder (docs generated by roxygen) #32

apulsipher opened this issue Nov 4, 2024 · 2 comments
Labels
bug Something isn't working CI/CD Creates or updates workflows
Milestone
ForeSITE 2

Comments

@apulsipher
Copy link
Contributor

Pre-commit shouldn't be running on the man/* folder because those files are auto-generated by roxygen and shouldn't be modified
@apulsipher apulsipher added the bug Something isn't working label Nov 4, 2024
@apulsipher
Copy link
Contributor Author

I looked into this a little bit and it seems that pre-commit is excluding man/, but for some reason that didn't hold with recent pull requests like #29.

@apulsipher apulsipher added the CI/CD Creates or updates workflows label Nov 5, 2024
@apulsipher apulsipher added this to the ForeSITE 2 milestone Nov 5, 2024
@apulsipher
Copy link
Contributor Author

I can't reproduce this bug, so I'm closing the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI/CD Creates or updates workflows
Projects
None yet
Milestone
ForeSITE 2
Development

No branches or pull requests
1 participant
@apulsipher