Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more (all?) AltoRouter options available #11

Open
mgussekloo opened this issue Jan 2, 2018 · 2 comments
Open

Make more (all?) AltoRouter options available #11

mgussekloo opened this issue Jan 2, 2018 · 2 comments

Comments

@mgussekloo
Copy link

AltoRouter already provides optional parameters, but Timber doesn't support them because this router strips question marks. I would like to use optional parameters, and maybe it wouldn't be a bad idea to just provide access to the AltoRouter object?

Something like

Routes::getRouter()->addRoutes([
['GET','/users/[i:id?]', function($params) {
etc...
})

@mgussekloo
Copy link
Author

Also, line 103 ($fullPath = is_readable($template);) returns true for files that exist, but may not be inside the theme directory... Maybe I can make a pull request to improve these two points?

@jasperrooduijn
Copy link

I was also searching for optinal parameters for my route. It would be really great i we could get this to work...Have you found any solution yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants