Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the code to be able to run on a national scale #254

Open
ciupava opened this issue Mar 4, 2021 · 4 comments
Open

Adapt the code to be able to run on a national scale #254

ciupava opened this issue Mar 4, 2021 · 4 comments
Assignees
Labels
essential enhancement Essential to get version 1 working

Comments

@ciupava
Copy link
Contributor

ciupava commented Mar 4, 2021

The current version of the model runs on the Devon data, we would like to be able to extend its application to other UK regions/areas.

@HSalat maybe we can share here some of our diagrams for the workflow we have in mind.

@ciupava ciupava added the enhancement New feature or request label Mar 4, 2021
@ciupava ciupava self-assigned this Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Branch ciupava-issue-254 created!

@Urban-Analytics Urban-Analytics deleted a comment from github-actions bot Mar 5, 2021
@Urban-Analytics Urban-Analytics deleted a comment from github-actions bot Mar 5, 2021
@Urban-Analytics Urban-Analytics deleted a comment from github-actions bot Mar 5, 2021
@ciupava
Copy link
Contributor Author

ciupava commented Mar 9, 2021

I am the person primarily dealing with this issue.
A first step is to reorganise part of the folders structures so that for examples things like the output folder is not within the input folder (currently devon_data). Possible alternatives for the folders structure are visualised (diagrams) and discussed elsewhere.
Another step towards a generalisation of the model is to soft-code parts that are currently hard-coded (ie for example the name 'Devon' used widely).
Several edits have been done in this sense already, when the new version is mature enough (and I will have more familiarity with GitHub also) it will be uploaded, still we have to decide if as a consistent or minor change.
This is issue is strongly connected with the issue opened by @HSalat #253, as the final structures folder (ie on the user's computer) will be dependent on these data download, which eventually will happen slightly differently from how it is happening now.

@ciupava ciupava added essential enhancement Essential to get version 1 working and removed enhancement New feature or request labels Mar 9, 2021
@ciupava
Copy link
Contributor Author

ciupava commented Mar 9, 2021

Note: the hard-coding and params setting was already mentioned in #229 and #231.

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Branch spoonerf-issue-254 created!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essential enhancement Essential to get version 1 working
Projects
None yet
Development

No branches or pull requests

5 participants