Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundancies in the R package #281

Open
3 tasks
spoonerf opened this issue May 7, 2021 · 0 comments
Open
3 tasks

Redundancies in the R package #281

spoonerf opened this issue May 7, 2021 · 0 comments

Comments

@spoonerf
Copy link
Contributor

spoonerf commented May 7, 2021

Just making note of this while it is still current rather than expecting anyone to do anything about it!

Some redundancies in the R disease model:

  • This has no real use: ` if(set_seed == TRUE) {

    seed <- rep
    set.seed(seed)
    } else {
    seed <- NULL
    }`

  • The rep, risk_cap, rank_assign and set_seed parameters in the run_status() function are no longer used

Areas that could be improved:

  • Currently all of the functions in the run_status() function are run every day. This is unnecessary for some functions, for example the mortality_risk() and sympt_risk functions could just be run once for each model run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant