Prepare for CRAN

[tomschenkjr]

Ran the package through R CMD check to look for outstanding errors that would cause issues in submitting to CRAN. Below are some issues that were identified:

• Malformed Description field: should contain one or more complete sentences.
• Non-standard license specification: Apache 2
• checking dependencies in R code ... WARNING '::' or ':::' imports not declared from: ‘httr’ ‘jsonlite’
• A few of the unit tests don't work

Here is the full output:

* using R version 3.5.0 (2018-04-23)
* using platform: x86_64-apple-darwin15.6.0 (64-bit)
* using session charset: UTF-8
* checking for file ‘AotClient/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘AotClient’ version ‘0.1.0’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘AotClient’ can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking DESCRIPTION meta-information ... NOTE
Malformed Description field: should contain one or more complete sentences.
Non-standard license specification:
  Apache 2
Standardizable: FALSE
* checking top-level files ... NOTE
File
  LICENSE
is not mentioned in the DESCRIPTION file.
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... WARNING
'::' or ':::' imports not declared from:
  ‘httr’ ‘jsonlite’
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking examples ... NONE
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘testthat.R’ ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  2: as.POSIXlt(data$timestamp)
  3: as.POSIXlt.default(data$timestamp)
  4: stop(gettextf("do not know how to convert '%s' to class %s", deparse(substitute(x)), 
         dQuote("POSIXlt")), domain = NA)
  
  ══ testthat results  ═════════════════════════════════════════════════════════
  OK: 11 SKIPPED: 0 FAILED: 5
  1. Error: unknown filter values return 200 and 0 length arrays (@test_client.R#31) 
  2. Failure: apply filters (@test_client.R#80) 
  3. Error: unknown filter values return 200 and 0 length arrays (@test_client.R#84) 
  4. Failure: apply filters (@test_client.R#98) 
  5. Error: unknown filter values return 200 and 0 length arrays (@test_client.R#102) 
  
  Error: testthat unit tests failed
  Execution halted
* checking PDF version of manual ...
 OK
* DONE
Status: 1 ERROR, 1 WARNING, 2 NOTEs

[vforgione]

This is super helpful. I'll let you in on a secret: I've never written a line of R before this. I really appreciate you digging in on it.

I'll do some homework and get this fixed up soon.

[tomschenkjr]

No problem! The code looks pretty good. Where do you want end-users to report bugs? This repo or elsewhere?

On Fri, Nov 9, 2018, 4:15 PM Vince Forgione ***@***.***> wrote: This is super helpful. I'll let you in on a secret: I've never written a line of R before this. I really appreciate you digging in on it. I'll do some homework and get this fixed up soon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABkC0V9M_iMBeUMqnyz7Nlip0dKalBAwks5utf5_gaJpZM4YW9h8> .

-- Tom Schenk Jr. [email protected] tomschenkjr.net

[vforgione]

This repo. We don't have a unified bug tracker.