Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor attributes are redundant #6

Open
geneorama opened this issue Mar 8, 2019 · 1 comment
Open

sensor attributes are redundant #6

geneorama opened this issue Mar 8, 2019 · 1 comment

Comments

@geneorama
Copy link
Collaborator

@vforgione I didn't catch what you were saying earlier, I see now that the attribute columns are totally unnecessary for sensors because there's a column that has the exact same information.

In R I would say that people rarely use attributes, but they're kind of useful and it's the right way to capture certain data.

I think it might be more efficient to return things like this as a list. Using this paradigm would break anyone depending on the existing code, but now's the time to make changes like that. Technically removing the attributes could also break people's workflow.

@geneorama
Copy link
Collaborator Author

Also, these attributes are all NULL

  attr(df, "subsystem") <- data$subsystem
  attr(df, "sensor") <- data$sensor
  attr(df, "parameter") <- data$parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant