Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umap coordinates for NewPeakSeurat #43

Open
leeanapeters opened this issue Sep 30, 2021 · 3 comments
Open

umap coordinates for NewPeakSeurat #43

leeanapeters opened this issue Sep 30, 2021 · 3 comments

Comments

@leeanapeters
Copy link

leeanapeters commented Sep 30, 2021

Hi there, thank you for creating this interesting package!

I am attempting to create my peak level Seurat object. I initially received an error when using PeakSeuratFromTransfer that there were no matching barcodes despite arranging them in the same order when aggregating peaks (the combined prepared Seurat object is has barcode suffixes _1-1, _2-1 etc, which was how I understood the Sierra barcode appending worked as well, but maybe I am incorrect?)

When I tried NewPeakSeurat I encountered another error. It seems to want tsne coordinates even though I am supplying umap coordinates in the function.

Here is what I did along with the error

umap.coords <- query[["proj.umap"]]@cell.embeddings

peaks.seurat <- NewPeakSeurat(peak.data = peak.counts,

  •                           annot.info = peak.annotations, 
    
  •                           cell.idents = populations, 
    
  •                           umap.coords = umap.coords,
    
  •                           min.cells = 0, min.peaks = 0)
    

[1] "Creating Seurat object with 35146 peaks and 60227 cells"
Warning: The following arguments are not used: row.names
[1] "Preparing feature table for DEXSeq"
Performing log-normalization
0% 10 20 30 40 50 60 70 80 90 100%
[----|----|----|----|----|----|----|----|----|----|
**************************************************|
[1] "No t-SNE coodinates included"
Error in umap.coords[colnames(peaks.seurat), ] : subscript out of bounds

Any help would be appreciated!

Thanks

@leeanapeters
Copy link
Author

After digging a bit more, I am going to try and re-run the aggregatepeaks portion and provide manual barcode labels now, hoping that solves the issue.

@pratarora
Copy link

Hi @leeanapeters

I think this issue was resolved in the new version available from github. Try installing the newer version. Also check #40 .

@rj-patrick
Copy link
Contributor

Hi @leeanapeters,

For aggregating multiple runs, by default with barcodes will be appended with '-1', '-2' etc. Looks like this is not the case for your data, so you will need to update the suffixes manually.

Regarding the t-SNE coordinates, yes this should be fixed in the current version as noted by @pratarora.

Cheers,
Ralph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants