Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT VCO locks mutex too often/too long in the GUI thread #138

Open
Xenakios opened this issue Dec 28, 2021 · 0 comments
Open

WT VCO locks mutex too often/too long in the GUI thread #138

Xenakios opened this issue Dec 28, 2021 · 0 comments

Comments

@Xenakios
Copy link

Xenakios commented Dec 28, 2021

and that causes audio pops/noise in the module's output.

The most offending mutex locking is at

std::lock_guard<std::recursive_mutex> lock(wavetable.mutex);

Since that method is run at each GUI update (dozens of times per second) when the module panel is in view, the audio thread will try to enter the mutex quite often while it is locked by the GUI thread, and because of how the audio processing is implemented (early return from process() ), pops/noise is heard in the module audio output.

Perhaps a solution that doesn't involve using a mutex lock for the module's thread safety could be devised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant