diff --git a/internal/aggregator/autocreate.go b/internal/aggregator/autocreate.go index 941758753..6efb3068e 100644 --- a/internal/aggregator/autocreate.go +++ b/internal/aggregator/autocreate.go @@ -54,7 +54,6 @@ type KnownTag struct { ID string `json:"id,omitempty"` Description string `json:"description,omitempty"` RawKind string `json:"raw_kind,omitempty"` - SkipMapping bool `json:"skip_mapping,omitempty"` Whitelist []string `json:"whitelist,omitempty"` } @@ -389,9 +388,6 @@ func publishDraftTags(meta *format.MetricMetaValue, knownTags []KnownTag) int { draftTag.RawKind = rawKind } } - if knownTag.SkipMapping { - draftTag.SkipMapping = true - } if len(meta.Tags) <= x { meta.Tags = append(make([]format.MetricMetaTag, 0, x+1), meta.Tags...) meta.Tags = meta.Tags[:x+1] diff --git a/internal/api/handler_easyjson.go b/internal/api/handler_easyjson.go index e64acde9b..95737de48 100644 --- a/internal/api/handler_easyjson.go +++ b/internal/api/handler_easyjson.go @@ -844,8 +844,6 @@ func easyjson888c126aDecodeGithubComVkcomStatshouseInternalFormat1(in *jlexer.Le } in.Delim('}') } - case "skip_mapping": - out.SkipMapping = bool(in.Bool()) default: in.SkipRecursive() } @@ -944,16 +942,6 @@ func easyjson888c126aEncodeGithubComVkcomStatshouseInternalFormat1(out *jwriter. out.RawByte('}') } } - if in.SkipMapping { - const prefix string = ",\"skip_mapping\":" - if first { - first = false - out.RawString(prefix[1:]) - } else { - out.RawString(prefix) - } - out.Bool(bool(in.SkipMapping)) - } out.RawByte('}') } func easyjson888c126aDecodeGithubComVkcomStatshouseInternalApi3(in *jlexer.Lexer, out *querySeries) { diff --git a/internal/api/sql.go b/internal/api/sql.go index db43957ff..858402fb3 100644 --- a/internal/api/sql.go +++ b/internal/api/sql.go @@ -224,6 +224,7 @@ func (b *queryBuilder) writeTagCond(lod *data_model.LOD, in bool) { sep, predicate = " AND ", " NOT IN " } metric := b.singleMetric() + version3StrcmpOn := b.version3StrcmpOn(metric, lod) for i, filter := range f.Tags { if filter.Empty() { continue @@ -231,7 +232,6 @@ func (b *queryBuilder) writeTagCond(lod *data_model.LOD, in bool) { b.WriteString(" AND (") // mapped tagID := format.TagID(i) - version3StrcmpOn := b.version3StrcmpOn(metric, i, lod) var hasMapped bool var hasValue bool var version3HasEmpty bool diff --git a/internal/api/sql_v3.go b/internal/api/sql_v3.go index 833a95040..00cf4094f 100644 --- a/internal/api/sql_v3.go +++ b/internal/api/sql_v3.go @@ -101,12 +101,8 @@ func (b *queryBuilder) tagValueIDsQueryV3(lod *data_model.LOD) *tagValuesSelectC return &q } -func (b *queryBuilder) version3StrcmpOn(metric *format.MetricMetaValue, tagX int, lod *data_model.LOD) bool { - version3StrcmpOn := lod.Version == Version3 && !b.strcmpOff - if !version3StrcmpOn || metric == nil || len(metric.Tags) <= tagX { - return version3StrcmpOn - } - return metric.Tags[tagX].SkipMapping +func (b *queryBuilder) version3StrcmpOn(metric *format.MetricMetaValue, lod *data_model.LOD) bool { + return lod.Version == Version3 && !b.strcmpOff } func (b *queryBuilder) mappedColumnNameV3(tagID string, lod *data_model.LOD) string { diff --git a/internal/format/format.go b/internal/format/format.go index 5e3daf8fc..cd8bf80e4 100644 --- a/internal/format/format.go +++ b/internal/format/format.go @@ -152,7 +152,6 @@ type MetricMetaTag struct { RawKind string `json:"raw_kind,omitempty"` // UI can show some raw values beautifully - timestamps, hex values, etc. ID2Value map[int32]string `json:"id2value,omitempty"` ValueComments map[string]string `json:"value_comments,omitempty"` - SkipMapping bool `json:"skip_mapping,omitempty"` // used only in v3 conveyor Comment2Value map[string]string `json:"-"` // Should be restored from ValueComments after reading IsMetric bool `json:"-"` // Only for built-in metrics so never saved or parsed diff --git a/internal/mapping/pipeline_v2.go b/internal/mapping/pipeline_v2.go index e5c6c3a48..b54e80470 100644 --- a/internal/mapping/pipeline_v2.go +++ b/internal/mapping/pipeline_v2.go @@ -77,8 +77,6 @@ func (mp *mapPipelineV2) mapTags(h *data_model.MappedMetricHeader, metric *tlsta continue } switch { - case tagMeta.SkipMapping: - h.SetSTag(tagMeta.Index, v.Value, tagIDKey) case tagMeta.Index == format.StringTopTagIndex: h.TopValue.S = v.Value if h.IsSKeySet {