-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a developer I want to be able to PATCH or PUT rollen in the Zaken API #1835
Comments
We are working on the development of ZAC and we would also very much like to be able to change (zaak)rollen with just one ZGW ZRC API request (PUT or possibly PATCH) instead of the two we now need to do (DELETE, followed by a CREATE). In ZAC users can (re-)assign ('verdelen') batches of up to 100 zaken in one go. This action results in a lot of ZGW API traffic to the zaakregister (OpenZaak in our case) and this is for a large part because we need to first delete and then create these zaakrollen for every zaak. And also, in the ZGW architecture this currently means that we receive and need to handle two notifications (from OpenNotificaties in our case): one for the zaakrol delete and one for the zaakrol create while we really are only interested in a single notificatie: zaakrole update. In other words: we find that the current ZGW ZRC API is too low-level for this (and possibly other) use case and we (and I think other zaakafhandelcomponents) would greatly benefit from an addition to this API to be able to update zaakrollen in one request. The following JIRA issue contains some more information specific for ZAC: https://dimpact.atlassian.net/browse/PZ-4371 |
Thanks Edgar! |
@Hugo-ter-Doest there may well be more places than just this where ZAC (and other components) would greatly benefit from higher-level handelinggedreven API's as compared to the current CRUD ones. Might be worthwhile to do an investigation at some point? |
@edgarvonk Do you really have an urgent (performance) problem right now? If so, does it solve the problem for you if we only add the PUT-operation to the |
Only the PUT would be fine! Actually I would prefer that even just to keep things simple. No, we don't have an urgent performance problem. Our main driver for this change is more to reduce complexity and improve reliability of our solution. But performance gains are always welcome for sure. :-) |
See PR #2489. You can view the addition of the PUT-operation to the @edgarvonk Does this satisfy your needs? |
Is there any reason why the |
@marnixdessing In commit 7492f1a of the PR I have relaxed on the validation such that you can update the |
@HenriKorver thanks! This will work for us :) |
Summary:
To reduce the number of requests it would be great if we can PATCH or PUT
rollen
(and other resources).Context:
In some cases a
rol
is created at a time where more information on therol
is unknown. In our particular implementation we're using a BPMN modeler (Camunda) so that (non-)developers can create resources such asrollen
at particular points in time in automated processes. The BPMN modeler is naive in the sense that it doesn't hold all information of every user and polluting it with that data is undesirable. Currently arol
gets created in the BPMN modeler but with sparse data (only theusername
is added to thebetrokkeneIdentificatie
).Current implementation:
A
rol
resource can be created or destroyed.Current inefficiencies:
A notification from the NRC alerts our Zaakafhandelcomponent that a
rol
is created. This sets in motion the processes to complete the information in the betrokkeneIdentificatie by:rol
rol
informationrol
if other data existsrol
(alerts the NRC)rol
(alerts the NRC) with updated dataBenefits:
The number of requests related to "editing" these resources would be halved.
The text was updated successfully, but these errors were encountered: