安定版リリースをHomebrewでインストールできるようにする #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umi1299
commented
Aug 5, 2023
Hiroshiba
reviewed
Aug 6, 2023
| "~/Library/Application Support/voicevox", | ||
| "~/Library/Application Support/voicevox-cpu", | ||
| "~/Library/Application Support/voicevox-engine", | ||
| "~/Library/Logs/voicevox-cpu", |
There was a problem hiding this comment.
次辺りにディレクトリが増える（"変わる"じゃなく"増える"なのは不具合ですが。。）ので追加しちゃいましょう！
Suggested change
| "~/Library/Logs/voicevox-cpu", | |
| "~/Library/Logs/voicevox", | |
| "~/Library/Logs/voicevox-cpu", |
There was a problem hiding this comment.
次のリリースのときに追加するPRを出そうと思います！ (ここをActionsで自動更新させるのは難しそうですね…)
Hiroshiba
reviewed
Aug 6, 2023
Hiroshiba
approved these changes
Aug 6, 2023
|
マージありがとうございます！ |
|
インストールできることを確認しました！！ |
|
@y-chan こんな感じでツイートする予定です！ 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VOICEVOXの安定版リリースをHomebrewでインストールできるようにします。
関連 Issue
VOICEVOX/voicevox#1451