Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Port pykeio/ort#218 #5

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jun 24, 2024

内容

pykeio#218 と同内容です。

多分 VOICEVOX/voicevox_core#725 の頃からVOICEVOX COREのi686-pc-windows-msvcは壊れていたのですが、リリース時かworkflow_dispatchでしかCIが回らないため気付きませんでした。

関連 Issue

スクリーンショット・動画など

その他

@qryxip qryxip requested a review from Hiroshiba June 24, 2024 19:10
@qryxip qryxip marked this pull request as draft June 24, 2024 19:14
@qryxip qryxip marked this pull request as ready for review June 24, 2024 19:22
@qryxip
Copy link
Member Author

qryxip commented Jun 24, 2024

お、もうマージされたっぽいのでdraft外します。

@Hiroshiba
Copy link
Member

そのうちort側がreleaseされればこちらも追従できそうだけど、それを待たずにマージしたいというニュアンスですかね? 👀
認識あってそうであればマージします!

@qryxip
Copy link
Member Author

qryxip commented Jun 25, 2024

ですね。

COREのリリースとortのリリースとではortの方が早いと思いますが、 VOICEVOX/voicevox_core#721VOICEVOX/voicevox_project#24 みたいなことをやるにあたって早めに検証可能な状態にしておきたいと思ってます。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit b6c41c6 into VOICEVOX:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants