Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global _options variable avoids using multi okayNav instance in one page #34

Open
pmoradei opened this issue Mar 9, 2016 · 2 comments

Comments

@pmoradei
Copy link

pmoradei commented Mar 9, 2016

Hi, very nice plugin!

My problem :
_options variable is declared globally and can cause problems if I use several okayNav instances in one page. Do you think it could become a instance property?

Same problem for the $navigation,$nav_visible,$nav_invisible variables. Do you think they could also become instance properties?

@VPenkov
Copy link
Owner

VPenkov commented Mar 15, 2016

Currently it's not possible to use okayNav in multiple instances for a variety of reasons. At least, not out of the box anyway.
But yeah, point taken, leaving this open for now.

@pmoradei
Copy link
Author

Ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants