Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard accessibility #39

Open
powrsurg opened this issue Apr 8, 2016 · 1 comment
Open

Keyboard accessibility #39

powrsurg opened this issue Apr 8, 2016 · 1 comment

Comments

@powrsurg
Copy link

powrsurg commented Apr 8, 2016

As someone that does accessibility testing quite often, I found the module to have a few issues:

  1. A user can tab to the hidden items with their keyboard, even if they're not visible. A user should not be able to tab to an item that is not visible.
  2. Tabbing to the ellipsis should occur before the navigation items to expand collapse.
  3. Missing keyboard functions (and ARIA attributes) for the Menubar role.

The first issue can be fixed by applying a tabindex="-1" to hidden links, and change them to tabindex="0" when they are exposed.

The second issue is simply an issue with reordering the item.

The third issue can be fixed by following the rules defined in this example: http://oaa-accessibility.org/example/25/

@VPenkov
Copy link
Owner

VPenkov commented Apr 11, 2016

That's some great feedback. Highly appreciated.
I recently got hired on a new job so I'll get right back to okayNav once I get ahold of things there, possibly even this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants