From 0c66507cef2c721af4045191988627565f43bad3 Mon Sep 17 00:00:00 2001 From: Karl Pierce Date: Mon, 22 Jan 2024 15:49:44 -0500 Subject: [PATCH] Try to get RALS working --- btas/generic/cp_als.h | 1 + unittest/ztensor_cp_test.cc | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/btas/generic/cp_als.h b/btas/generic/cp_als.h index 7335e723..52866628 100644 --- a/btas/generic/cp_als.h +++ b/btas/generic/cp_als.h @@ -659,6 +659,7 @@ namespace btas { Tensor temp(A[n].extent(0), rank); Tensor an(A[n].range()); + } #ifdef BTAS_HAS_INTEL_MKL // Computes the Khatri-Rao product intermediate diff --git a/unittest/ztensor_cp_test.cc b/unittest/ztensor_cp_test.cc index d01d77a5..66ea12c6 100644 --- a/unittest/ztensor_cp_test.cc +++ b/unittest/ztensor_cp_test.cc @@ -146,17 +146,14 @@ TEST_CASE("ZCP") { SECTION("RALS MODE = 4, Finite rank") { CP_RALS A1(Z4); conv.set_norm(norm4.real()); - double diff = A1.compute_rank(65, conv, 1, true, 65); + double diff = A1.compute_rank(67, conv, 1, true, 65); CHECK(std::abs(diff) <= epsilon); } SECTION("RALS MODE = 4, Finite error"){ CP_RALS A1(Z4); conv.set_norm(norm4.real()); - double diff = A1.compute_error(conv, 1e-5, 1, 100, true, 65); - std::cout.precision(16); - std::cout << diff << std::endl; - std::cout << epsilon << std::endl; - std::cout << A1.get_factor_matrices()[1].extent(1) << std::endl; + conv.verbose(true); + double diff = A1.compute_error(conv, 1e-5, 1, 67, true, 65); CHECK(std::abs(diff) <= epsilon); } #if BTAS_ENABLE_TUCKER_CP_UT