Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think, single quotation do not need escape. #29

Open
aoisensi opened this issue Sep 14, 2020 · 4 comments
Open

I think, single quotation do not need escape. #29

aoisensi opened this issue Sep 14, 2020 · 4 comments
Labels

Comments

@aoisensi
Copy link

At least Dota 2 interprets \' as they are.

@aoisensi aoisensi changed the title I think, single quotation is not need escape. I think, single quotation do not need escape. Sep 14, 2020
@rossengeorgiev
Copy link
Member

Could you the a file that reproduces the issue?

@aoisensi
Copy link
Author

aoisensi commented Dec 8, 2020

@rossengeorgiev
Copy link
Member

So the issue is that when you dump a dict, then ' are escaped, correct?

Here are all the characters they escape from the SDK, which includes ': https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/tier1/utlbuffer.cpp#L54-L69

I guess the only way to resolve this is introducing a parameter to enable/disable escaping. That will also resolve #28

@aoisensi
Copy link
Author

Yes. But, I want to exclusion only '.
I need to escape another characters.
The SDK is Source1.
Dota2's SDK is Source2.
Perhaps the parser of Source1 is not the same as the parser of Source2.
I'm using edited version of this library.
https://github.com/nihongoka/dota2/blob/7e19285702203957ecb2b50b88de97241305515b/scripts/vdf/__init__.py#L61
https://github.com/ValvePython/vdf/blob/master/vdf/__init__.py#L62
Sorry for late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants