Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tap-to-click, natural scrolling and more. Add libinput pointer settings. #1291

Closed
wants to merge 1 commit into from

Conversation

chenx-dust
Copy link

@chenx-dust chenx-dust commented May 9, 2024

For better experience, I added these useful parameters to change libinput pointer configs:

  • --tap-to-click enable tap-to-click feature for pointer devices
  • --tap-and-drag enable tap-and-drag feature for pointer devices
  • --drag-lock enable drag-lock feature for pointer devices
  • --natural-scrolling enable natural scrolling for ...
    • none => No pointer device
    • touchpad => Only for touchpad
    • mouse => Only for mouse
    • all => All pointer device

Btw, there are plenty of configurable things for libinput, should these options become a config file or sth else for setting up easily? (Ref. libinput document)

@misyltoad
Copy link
Collaborator

Does tap to click mirror what we already do for touch emulation elsewhere?

@chenx-dust
Copy link
Author

Does tap to click mirror what we already do for touch emulation elsewhere?

Nope. libinput regards pointer (mouse, touchpad, etc.) and touchscreen as two different kinds of input. (Ref. wlserver_new_input function in src/wlserver.cpp) There shouldn't be any side effect on touch input. I haven't seen any mirror behavior happened in my real experience.

Btw, this pr is mostly for adjust touchpad experience. Tap-to-click is necessary for those devices with unclickable touchpad.

@chenx-dust
Copy link
Author

I probably misunderstood your points. Do you mean there is some touch emulation for pointer input? Is there any other information? I'll look into it.

@misyltoad
Copy link
Collaborator

Ah tap as in trackpad. We should make that more explicit.

@chenx-dust
Copy link
Author

Ah tap as in trackpad. We should make that more explicit.

Sorry for my vague sayings. libinput called these trackpad-like devices as "pointer", so I continued using it.

@chenx-dust
Copy link
Author

Any news?

@chenx-dust chenx-dust closed this by deleting the head repository Jul 5, 2024
@misyltoad
Copy link
Collaborator

Sorry, I didn't get your email. :(

It looks fine to merge if you want to re-open.

@chenx-dust
Copy link
Author

Sorry, I didn't get your email. :(

It looks fine to merge if you want to re-open.

Aha, actually I'm adding more setting options for this. It won't take long.

@chenx-dust
Copy link
Author

#1406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants