-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled fsr for downscaling #702
base: master
Are you sure you want to change the base?
Conversation
Sorry to bug, but would you mind explaining how this works to me? How does FSR matter here for downscaling? Isn't downscaling directly from a higher resolution good enough for this case, or does it handle it differently, like by upscaling the original res to a higher res, and then downscaling? |
Hi @orowith2os, as you can see by the screenshots, downscaling in gamescope does not produce good results due to a lack of a good downscaling algorithm. FSR makes the image smoother and less aliased, it is used as if it were a downscaling algorithm (although it is for upscaling). |
Since this PR request was made before #740, does it mean that the effect of this FSR "downscaling" is identical to enabling FSR on native resolution (since no actual downscaling is being performed)? |
Hi @rKsanu2MMYvypWePtQWM , no. When rendering in a higher than native resolution FSR used bilinear filtering (I think, from reading the code) in the image before it was resized, so it looks smoother and less aliased. However I think that a dedicated shader for doing that is less of a |
Hi,
This PR is related to issue #692, besides upscaling, FSR can yield good results for downscaling.
This is the current result of gamescope (from 5120x2160 to 2560x1080):
This is with fsr for downscaling (from 5120x2160 to 2560x1080):
The power lines, stage mounts, and everything else is better defined, with less jagged edges.