-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCP environment variable usage #656
Comments
@gfting i will take this one |
Thanks! I think after this is merged in, then we can merge in #630. |
can't we just put the env var base64 encoded and then decode it from the env var? that's what I do at https://github.com/aadibajpai/VandyPurger/blob/master/bot.py#L24 for using the Google Sheets API and it works well enough |
I'm not sure I agree with splitting up the GCP service account env var, as the properties come from a service account JSON config file download and can't be used separately. base64 encoding is a good option, although will be just as long, only prevents weird newline issues depending on what format you're keeping the env var. |
Aren't the properties consist though? It's just seems unnatural to have entire json as env variable |
Currently, using the JSON as a string can lead to errors and inconsistencies. We should instead factor out individual properties into their own environment variables, as Dmitry suggested.
The text was updated successfully, but these errors were encountered: