Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[#11] Add localization for slides #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jardon
Copy link
Member

@jardon jardon commented Sep 12, 2024

  • Add en_GB.po file
  • Pass strings to gettext before constructing slides
  • Add translation support metainfo

Closes #11

- Add en_GB.po file
- Pass strings to gettext before constructing slides
- Add translation support metainfo
@jardon jardon marked this pull request as ready for review September 14, 2024 19:45
@jardon
Copy link
Member Author

jardon commented Sep 14, 2024

The changes to the textdomain might not be completely necessary, but I'm not completely sure. Thoughts are welcome.

Does it need to be vanilla-tour or just tour?

@jardon jardon requested a review from Muqtxdir September 14, 2024 19:48
Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jardon

@Muqtxdir
Copy link
Member

it's fine with keeping it as vanilla-tour

@kbdharun kbdharun self-requested a review September 15, 2024 13:03
@kbdharun kbdharun self-assigned this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tour.json to a Python/GTK friendly format for translation support using Gettext
3 participants