Skip to content

Commit

Permalink
Remove TODO comment which has been addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
sallybg committed Oct 1, 2024
1 parent c213655 commit bdb099c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/mavedb/scripts/populate_mapped_variants.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def populate_mapped_variant_data(db: Session, urns: Sequence[Optional[str]], all
mapped_variants = [variant_from_mapping(db=db, mapping=mapped_score, dcd_mapping_version=dcd_mapping_version) for mapped_score in mapped_scores]
logger.debug(f"Done constructing {len(mapped_variants)} mapped variant objects.")

# TODO check if sqlalchemy null() registers as None
num_successful_variants = len([variant for variant in mapped_variants if variant.post_mapped != null()])
if num_successful_variants == 0:
score_set.mapping_state = MappingState.failed
Expand Down

0 comments on commit bdb099c

Please sign in to comment.