Add some basic tests. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencap
approved these changes
Sep 16, 2024
tests/routers/test_experiments.py
Outdated
Comment on lines
122
to
151
| def test_can_update_own_private_experiment_short_description(session, client, setup_router_db): | ||
| experiment = create_experiment(client) | ||
| experiment_post_payload = deepcopy(TEST_MINIMAL_EXPERIMENT) | ||
| experiment_post_payload.update({"experimentSetUrn": experiment["experimentSetUrn"], "shortDescription": "New description"}) | ||
| response = client.post("/api/v1/experiments/", json=experiment_post_payload) | ||
| assert response.status_code == 200 | ||
| assert response.json()["experimentSetUrn"] == experiment["experimentSetUrn"] | ||
| assert response.json()["shortDescription"] == "New description" | ||
|
|
||
|
|
||
| def test_can_update_own_private_experiment_abstract(session, client, setup_router_db): | ||
| experiment = create_experiment(client) | ||
| experiment_post_payload = deepcopy(TEST_MINIMAL_EXPERIMENT) | ||
| experiment_post_payload.update({"experimentSetUrn": experiment["experimentSetUrn"], "abstractText": "New abstract"}) | ||
| response = client.post("/api/v1/experiments/", json=experiment_post_payload) | ||
| assert response.status_code == 200 | ||
| assert response.json()["experimentSetUrn"] == experiment["experimentSetUrn"] | ||
| assert response.json()["abstractText"] == "New abstract" | ||
|
|
||
|
|
||
| def test_can_update_own_private_experiment_method(session, client, setup_router_db): | ||
| experiment = create_experiment(client) | ||
| experiment_post_payload = deepcopy(TEST_MINIMAL_EXPERIMENT) | ||
| experiment_post_payload.update({"experimentSetUrn": experiment["experimentSetUrn"], "methodText": "New method"}) | ||
| response = client.post("/api/v1/experiments/", json=experiment_post_payload) | ||
| assert response.status_code == 200 | ||
| assert response.json()["experimentSetUrn"] == experiment["experimentSetUrn"] | ||
| assert response.json()["methodText"] == "New method" | ||
|
|
||
|
|
There was a problem hiding this comment.
I believe we have tests already for these operations:
mavedb-api/tests/routers/test_experiments.py
Lines 566 to 583 in d87b726
There was a problem hiding this comment.
Thanks Ben! I didn't notice this test. I'll delete the duplicate tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly in experiment and score set view models.